Re: libc/printf.c

[Tim Newsham <newsham@uhunix.uhcc.Hawaii.Edu> writes:]

>static
>__fprintf(FILE *fp, char *fmt, int *argptr)
> char buf[BUFSIZ], *p, c;
>...
>this is called by fprintf() as well as printf(). fixed sized
>buffer used on the stack. Could be the source of many core dumps
>and security violations (ie. old fingerd bug).

Well, now that we have a telnet server I guess this matters more. I'm open
to patches; the obvious one just caps _doscan() at a limit.

> switch((scale<<4) | size) {
>[...]
> case (INT<<3) | LONG:
>all the other cases were << 4 like the switch().

This is code imported from BSD, and the current scanf() code is very
different. It sure looks wrong to me, and yet it seems to work. I just
traced through the code, and the assignment case for the longword *is*
reached.

>yet another post... maybe I should have wrote the questions down
>and asked them all at once....

Fixed. :-)

>It doesnt appear the signal() library call does anything
>at the present time. Is this indeed the case?

Yup. In bringing up networking I fixed the event handling code, so now we
have a basis for doing the rest of signal handling. I'd expect this to
follow after v1.4, unless somebody else wants to jump in.

                                                Thanks,
                                                Andy
Received on Tue Aug 30 06:20:22 1994